[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Snapshot: 2007-06-18

From: boud
Subject: Re: Snapshot: 2007-06-18
Date: Sun, 24 Jun 2007 03:40:10 +0200 (CEST)

hi Dmitry,

On Mon, 18 Jun 2007, Dmitry Borodaenko wrote:

Yet another snapshot uploaded, includes the fix for the fix for #20134
(hope I got it right this time ;-), and an overhaul of translations
loosely based on Boud's separate translations patch, and following the
ideas discussed back in march.

Changes: translation is displayed in place of original in full mode
(when clicking to view the message) -- and the other way around,
original is listed and displayed in place of preferred translation,
all translations are dropped from replies list and are only available
through the list of translations in message info line, reply button is
not displayed on translation (no sense to enforce this latter rule
more strictly, as messages still can gain and loose status of
translation by changing the rating of their relation to Translation

Please give feedback, how does it compare to separate translation 0.2 patch?

It definitely is on the right track and looks good.

i'm a little bit worried that the user might get confused about the
reversed ID numbers of article + translations, but i think we should be
able to fix things so that a user who notices this will be able to say,
"well, it works anyway" and either forget about it or else read the code
and understand it more deeply.

There are a few bugs :) - related to the fact that some of the various links
such as message_info, Add another focus, edit, etc. need to be swapped as well.

* Add another focus:  it's a good thing that this now refers to the parent
message - it removes the error that a user adds only the translation, instead
of the parent message, to a focus. i think this does not requiring fixing.

* the message_info and edit links and the moderator buttons and the actual
operations they do need fixing - right now i need to sleep - i'll propose
a patch if i have time to do it before you do it. :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]