Re: [rdiff-backup-users] Automatic setting of "chars_to_quote"

[Robert Shaw]

Hi Ben,

I fixed this problem with the attached patches. It seems to work now.  
Can you please review the changes and roll them into your code  
officially?

Thanks!!!
-Robert

On Jun 16, 2004, at 8:51 PM, Robert Shaw wrote:

> Hi Ben,
>
> On Jun 8, 2004, at 3:49 PM, Ben Escoto wrote:
> > Try using --override-chars-to-quote '' (i.e. pass this option an empty
> > string).  This is an undocumented option and definitely hasn't been
> > tested for what you want to do.
>
> I've been using this option in my backup tests and it seems to work ok  
> most of the time. However, if I have a backup I've done using  
> --override-chars-to-quote '' and I try to do the following:
>
> rdiff-backup --remove-older-than 60D /path/to/backup
>
> It crashes with the following stack trace:
>
> Traceback (most recent call last):
>   File "/opt/local/bin/rdiff-backup", line 23, in ?
>     rdiff_backup.Main.Main(sys.argv[1:])
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 270, in  
> Main
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 248, in  
> take_action
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 727, in  
> RemoveOlderThan
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 669, in  
> require_root_set
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 690, in  
> single_set_fs_globals
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line  
> 394, in get_fsabilities_readwrite
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line  
> 154, in init_readwrite
>   File  
> "/opt/darwinports/dports/python/py-rdiff-backup/work/destroot/opt/ 
> local/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line  
> 177, in compare_chars_to_quote
> AttributeError: 'module' object has no attribute 'FatalError'
>
> I'm using the latest code from CVS (as of yesterday). If I create a  
> backup that did not use --override-chars-to-quote '' the above command  
> works just fine.
>
> Can you look into this and fix it?
>
> Thanks!
> -Robert

patch-fs_abilities.py
Description: Binary data

patch-Main.py
Description: Binary data