[Rdiff-backup-commits] rdiff-backup CHANGELOG rdiff_backup/fs_abilitie...

[Andrew Ferguson]

CVSROOT:        /sources/rdiff-backup
Module name:    rdiff-backup
Changes by:     Andrew Ferguson <owsla> 08/12/18 00:44:24

Modified files:
        .              : CHANGELOG 
        rdiff_backup   : fs_abilities.py 

Log message:
        Test for symlink permissions now produces a functioning symlink.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/rdiff-backup/CHANGELOG?cvsroot=rdiff-backup&r1=1.325&r2=1.326
http://cvs.savannah.gnu.org/viewcvs/rdiff-backup/rdiff_backup/fs_abilities.py?cvsroot=rdiff-backup&r1=1.58&r2=1.59

Patches:
Index: CHANGELOG
===================================================================
RCS file: /sources/rdiff-backup/rdiff-backup/CHANGELOG,v
retrieving revision 1.325
retrieving revision 1.326
diff -u -b -r1.325 -r1.326
--- CHANGELOG   17 Dec 2008 23:07:11 -0000      1.325
+++ CHANGELOG   18 Dec 2008 00:44:24 -0000      1.326
@@ -1,6 +1,9 @@
 New in v1.2.3 (????/??/??)
 ---------------------------
 
+Test for symlink permissions now produces a functioning symlink. Thanks to
+Julien Poffet for reporting the issue. (Andrew Ferguson)
+
 Fix for crash when deleting read-only files on Windows. (Patch from Josh Nisly)
 
 Fix for Python 2.2 in win_acls.py (Closes Savannah bug #24922).

Index: rdiff_backup/fs_abilities.py
===================================================================
RCS file: /sources/rdiff-backup/rdiff-backup/rdiff_backup/fs_abilities.py,v
retrieving revision 1.58
retrieving revision 1.59
diff -u -b -r1.58 -r1.59
--- rdiff_backup/fs_abilities.py        13 Nov 2008 01:14:59 -0000      1.58
+++ rdiff_backup/fs_abilities.py        18 Dec 2008 00:44:24 -0000      1.59
@@ -542,16 +542,14 @@
                sym_source.touch()
                sym_dest = dir_rp.append("symlinked_file2")
                try:
-                       sym_dest.symlink(sym_source.path)
+                       sym_dest.symlink("symlinked_file1")
                except (OSError, AttributeError):
                        self.symlink_perms = 0
                else:
                        sym_dest.setdata()
                        assert sym_dest.issym()
-                       orig_umask = os.umask(077)
                        if sym_dest.getperms() == 0700: self.symlink_perms = 1
                        else: self.symlink_perms = 0
-                       os.umask(orig_umask)
                        sym_dest.delete()
                sym_source.delete()