[Rdiff-backup-bugs] [bug #21202] Crash : AssertionError: no ownership of ...

[Marc Horowitz]

Follow-up Comment #4, bug #21202 (project rdiff-backup):

oops.  I mis-unmangled what savannah did to the python code below.  I took a
look at what's in CVS, and I'd like to change my comments a little.

The code in rev 1.41 will work with a mode 600 file, but it will fail with a
mode 000 file, since the code assumes that the file can be chmod'ed only if
the process uid matches the file owner.  In AFS, this is not true.  It ends up
printing permission denied, since the chmod step is skipped.

In fact, I'm leaning further towards the patch in my previous comment.  In
AFS, even root cannot read the mode 000 file, so the check for process_uid !=
0 is incorrect; we want to try to chmod the file even as root.  And the
readable() test is redundant.  If the file was readable, the code would never
reach the except: block, so even if the file appears readable, the chmod
should be attempted.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21202>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/