Re: [Rapp-dev] Have an extra look at commit e4a5, fixing a bug exposed by fixing MAX

[Hans-Peter Nilsson]

> Date: Sun, 12 Dec 2010 15:50:50 +0100
> From: Hans-Peter Nilsson <address@hidden>

> While looking into fixing and adjusting the morph bin overlap
> checks mentioned previously, I noticed that the MAX macro in the
> test-suite was... MIN.

I can't believe I didn't check other instancies of this macro!
Like, the one in driver/rapp_util.h which had the same bug which
just bit me, affecting overlap-checking in
rapp_morph_dilate_rect_bin and rapp_morph_erode_rect_bin ...but
which happened to be hidden due to the "double" overlap-check
that Johan A. commented on some time ago (one check missed it,
the other caught it, you can probably guess what happened when
that was fixed).  And which probably would have gone unnoticed
if I had changed the "padding is half the max SE side" to
"padding is half the corresponding SE side" before removing the
double overlap checks.

Let that be a warning to you all.

brgds, H-P