Re: [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

[Thomas Huth]

On 02/05/2024 22.08, Michael Tokarev wrote:
> 02.05.2024 23:05, Richard Henderson wrote:
> > On 5/2/24 12:40, Michael Tokarev wrote:
> > > Revert "gitlab-ci: Disable the riscv64-debian-cross-container by default"
> > > This reverts commit f51f90c65ed7706c3c4f7a889ce3d6b7ab75ef6a.
> > >
> > > Hopefully it wont be very unstable.
> > >
> > > Since riscv64 is now a release architecture in debian, we can try switching
> > > to debian testing instead of debian sid.  Also, debian-ports part of the
> > > archive isn't needed anymore.
> >
> > So... please update debian-riscv64-cross.docker.
>
> debian-riscv64-cross.docker is generated by lcitool.
> It looks like lcitool has to be updated for this.

Updating lcitool isn't too hard. Simply type "make lcitool-refresh" in your 
build directory - this should initialize the tests/lcitool/libvirt-ci 
submodule and regenerate the dockerfiles. Then you can do your change in 
tests/lcitool/libvirt-ci and run the refresh command again to update the 
dockerfiles. Once you're happy with the results, fork 
https://gitlab.com/libvirt/libvirt-ci on gitlab, push your changes into your 
fork and then open a merge request against the upstream libvirt-ci repository.

> > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> > > ---
> > >   .gitlab-ci.d/container-cross.yml | 1 -
> > >   1 file changed, 1 deletion(-)
> > >
> > > diff --git a/.gitlab-ci.d/container-cross.yml 
> > > b/.gitlab-ci.d/container-cross.yml
> > > index e3103940a0..dbffed3f21 100644
> > > --- a/.gitlab-ci.d/container-cross.yml
> > > +++ b/.gitlab-ci.d/container-cross.yml
> > > @@ -77,7 +77,6 @@ riscv64-debian-cross-container:
> > >     allow_failure: true
> > >     variables:
> > >       NAME: debian-riscv64-cross
> > > -    QEMU_JOB_OPTIONAL: 1
> >
> > But you can't do this until the above is done.
>
> I don't see a reason why not.  Adding debian-ports archive does nothing
> and doesn't hurt either.
>
> Switching to testing is a different matter.
>
> This thing works now with sid/unstable, this is what this patch is about.

But this doesn't match the patch description - there you talk about 
switching to testing and that the ports are not needed anymore, so this is 
confusing. I'd suggest to update at least the patch description if we 
continue with sid.

 Thomas