[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFL
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description |
Date: |
Mon, 6 May 2019 16:17:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/6/19 4:04 PM, Laszlo Ersek wrote:
> On 05/04/19 15:35, Philippe Mathieu-Daudé wrote:
>> In commit 1cab464136b4 we incorrectly described the
>> EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
>> options to the EDK2 build tools, but it only expands
>> the CFLAGS (not to the CPPFLAGS).
>> Update the description to be more accurate.
>>
>> Reported-by: Laszlo Ersek <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> roms/Makefile | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/roms/Makefile b/roms/Makefile
>> index 0ce84a45ad5..f020102c866 100644
>> --- a/roms/Makefile
>> +++ b/roms/Makefile
>> @@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
>> $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
>> $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
>>
>> -# Build scripts can pass compiler/linker flags to the EDK2 build tools
>> -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
>> +# Build scripts can pass compiler/linker flags to the EDK2
>> +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
>
> please 'tr -s " "' in the above.
Sharp eagle eye!
>
> With that:
>
> Reviewed-by: Laszlo Ersek <address@hidden>
Thanks :)
>
> Thanks
> Laszlo
>
>> # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
>> #
>> # Example:
>>
>