[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERR
From: |
Laurent Vivier |
Subject: |
[Qemu-trivial] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf |
Date: |
Fri, 3 May 2019 13:19:47 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Avoid to clutter stdout until explicitly requested
(with -d guest_errors):
$ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
Bad SWSTYLE=0x04
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/net/pcnet.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index d9ba04bdfc62..16683091c939 100644
--- a/hw/net/pcnet.c
+++ b/hw/net/pcnet.c
@@ -36,6 +36,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "hw/qdev.h"
#include "net/net.h"
#include "net/eth.h"
@@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap,
uint32_t val)
val |= 0x0300;
break;
default:
- printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
+ qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
+ val & 0xff);
val = 0x0200;
break;
}
--
2.20.1
- [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 03/12] CODING_STYLE: indent example code as all others, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- Re: [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf,
Laurent Vivier <=
- [Qemu-trivial] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 03/12] CODING_STYLE: indent example code as all others, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- Re: [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03