[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Remove old *-config-devices.mak.d

From: Eric Blake
Subject: Re: [Qemu-trivial] [PATCH] configure: Remove old *-config-devices.mak.d files when running configure
Date: Mon, 11 Mar 2019 11:21:27 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/11/19 5:29 AM, Thomas Huth wrote:
> When running "make" in a build directory from the pre-Kconfig merge time,
> the build process currently fails with:
>  make: *** No rule to make target `.../default-configs/pci.mak',
>   needed by `aarch64-softmmu/config-devices.mak'.  Stop.
> To make sure that this problem at least goes away when the user runs
> "configure" (or "sh config.status") again, we have to make sure that
> we re-generate the .mak.d files. Thus remove the old stale files
> while running the configure script.
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  configure | 3 +++
>  1 file changed, 3 insertions(+)

What are the conditions for make deciding it needs to rerun
config.status? Are end users still going to get 'make' failing with the
cryptic message (where we just advise on-list and on-wiki to
'./config.status' to fix it), or is there a way to build in a dependency
so that the makefile itself knows that if config.status has to be rerun,
that takes priority over any other rule that depends on .mak files?

> diff --git a/configure b/configure
> index b354e74..32c847f 100755
> --- a/configure
> +++ b/configure
> @@ -1792,6 +1792,9 @@ EOF
>  exit 0
>  fi
> +# Remove old dependency files to make sure that they get properly regenerated
> +rm -f *-config-devices.mak.d
> +
>  if ! has $python; then
>    error_exit "Python not found. Use --python=/path/to/python"
>  fi

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]