[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR)
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf |
Date: |
Mon, 11 Mar 2019 11:32:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
Oops 'fprintf' -> 'printf' in patch subject.
On 3/11/19 11:27 AM, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested
> (with -d guest_errors):
>
> $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
> Bad SWSTYLE=0x04
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Helge patch "pcnet: Avoid warning when switching back to 16bit mode"
> remembered me I had this one somewhere.
> ---
> hw/net/pcnet.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
> index d9ba04bdfc..16683091c9 100644
> --- a/hw/net/pcnet.c
> +++ b/hw/net/pcnet.c
> @@ -36,6 +36,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/qdev.h"
> #include "net/net.h"
> #include "net/eth.h"
> @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t
> rap, uint32_t val)
> val |= 0x0300;
> break;
> default:
> - printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
> + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
> + val & 0xff);
> val = 0x0200;
> break;
> }
>