qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_new0


From: Alex Bennée
Subject: Re: [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_new0
Date: Mon, 26 Nov 2018 11:27:00 +0000
User-agent: mu4e 1.1.0; emacs 26.1.90

Li Qiang <address@hidden> writes:

> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: address@hidden
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Li Qiang <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  target/i386/hax-all.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index d2e512856b..502ce6f0af 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
>          return 0;
>      }
>
> -    vcpu = g_malloc(sizeof(struct hax_vcpu_state));
> -    if (!vcpu) {
> -        fprintf(stderr, "Failed to alloc vcpu state\n");
> -        return -ENOMEM;
> -    }
> -
> -    memset(vcpu, 0, sizeof(struct hax_vcpu_state));
> +    vcpu = g_new0(struct hax_vcpu_state, 1);
>
>      ret = hax_host_create_vcpu(hax_global.vm->fd, id);
>      if (ret) {
> @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
>          return hax->vm;
>      }
>
> -    vm = g_malloc(sizeof(struct hax_vm));
> -    if (!vm) {
> -        return NULL;
> -    }
> -    memset(vm, 0, sizeof(struct hax_vm));
> +    vm = g_new0(struct hax_vm, 1);
> +
>      ret = hax_host_create_vm(hax, &vm_id);
>      if (ret) {
>          fprintf(stderr, "Failed to create vm %x\n", ret);


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]