[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-arm] [PATCH v2 01/14] hw/input/pckbd: Use qemu_
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-arm] [PATCH v2 01/14] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf |
Date: |
Sun, 24 Jun 2018 00:48:07 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/22/2018 04:24 PM, Thomas Huth wrote:
> On 22.06.2018 15:40, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> hw/input/pckbd.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
>> index f33e3fc63d..26aeac2326 100644
>> --- a/hw/input/pckbd.c
>> +++ b/hw/input/pckbd.c
>> @@ -22,6 +22,7 @@
>> * THE SOFTWARE.
>> */
>> #include "qemu/osdep.h"
>> +#include "qemu/log.h"
>> #include "hw/hw.h"
>> #include "hw/isa/isa.h"
>> #include "hw/i386/pc.h"
>> @@ -308,7 +309,8 @@ static void kbd_write_command(void *opaque, hwaddr addr,
>> /* ignore that */
>> break;
>> default:
>> - fprintf(stderr, "qemu: unsupported keyboard cmd=0x%02x\n",
>> (int)val);
>> + qemu_log_mask(LOG_GUEST_ERROR,
>> + "unsupported keyboard cmd=0x%02lx\n", val);
>
> Sorry for not spotting it in v1 already, but val is a uint64_t value, so
> you need PRIx64 as format string here, otherwise you'll get an error
> with 32-bit compilers.
Good catch.
Our last CI tested 32-bit arch is MXE Win32.
- [Qemu-trivial] [PATCH v2 00/14] hw/arm: use qemu_log_mask instead of fprintf, Philippe Mathieu-Daudé, 2018/06/22
- [Qemu-trivial] [PATCH v2 01/14] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/22
- [Qemu-trivial] [PATCH v2 03/14] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/22
- [Qemu-trivial] [PATCH v2 04/14] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/22
- [Qemu-trivial] [PATCH v2 05/14] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/22
- [Qemu-trivial] [PATCH v2 06/14] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/22
- [Qemu-trivial] [PATCH v2 07/14] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/22