[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 1/4] m68k: fix subx mem, mem instruction
From: |
Laurent Vivier |
Subject: |
[Qemu-trivial] [PULL 1/4] m68k: fix subx mem, mem instruction |
Date: |
Tue, 1 May 2018 15:55:44 +0200 |
From: Pavel Dovgalyuk <address@hidden>
This patch fixes decrement of the pointers for subx mem, mem instructions.
Without the patch pointers are decremented by OS_* constant value instead of
retrieving the corresponding data size and using it as a decrement.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
target/m68k/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 6beaf9ed66..e407ba2db3 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -3166,11 +3166,11 @@ DISAS_INSN(subx_mem)
opsize = insn_opsize(insn);
addr_src = AREG(insn, 0);
- tcg_gen_subi_i32(addr_src, addr_src, opsize);
+ tcg_gen_subi_i32(addr_src, addr_src, opsize_bytes(opsize));
src = gen_load(s, opsize, addr_src, 1, IS_USER(s));
addr_dest = AREG(insn, 9);
- tcg_gen_subi_i32(addr_dest, addr_dest, opsize);
+ tcg_gen_subi_i32(addr_dest, addr_dest, opsize_bytes(opsize));
dest = gen_load(s, opsize, addr_dest, 1, IS_USER(s));
gen_subx(s, src, dest, opsize);
--
2.14.3
- [Qemu-trivial] [PULL 0/4] M68k for 2.13 patches, Laurent Vivier, 2018/05/01
- [Qemu-trivial] [PULL 4/4] hw/m68k/mcf5208: Fix trivial typo in board description, Laurent Vivier, 2018/05/01
- [Qemu-trivial] [PULL 1/4] m68k: fix subx mem, mem instruction,
Laurent Vivier <=
- [Qemu-trivial] [PULL 3/4] m68k: remove dead code (Coverity CID1390617), Laurent Vivier, 2018/05/01
- [Qemu-trivial] [PULL 2/4] m68k: Fix floatx80_lognp1 (Coverity CID1390587), Laurent Vivier, 2018/05/01
- Re: [Qemu-trivial] [Qemu-devel] [PULL 0/4] M68k for 2.13 patches, Peter Maydell, 2018/05/01