[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report() |
Date: |
Fri, 22 Dec 2017 16:21:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Alistair Francis <address@hidden> writes:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N; {s|fprintf(stderr,
> "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'
> \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
>
> Some lines where then manually tweaked to pass checkpatch.
>
> The 'qemu: ' prefix was manually removed from the hw/arm/boot.c file.
Elsewhere, too. Suggest "The 'qemu: ' prefix was manually removed from
several error messages." Perhaps this could be done on commit.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Cc: address@hidden
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
With the commit message touched up:
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-trivial] [PATCH v6 00/29] Remove some of the fprintf(stderr, "*, Alistair Francis, 2017/12/20
- [Qemu-trivial] [PATCH v6 03/29] Fixes after renaming __FUNCTION__ to __func__, Alistair Francis, 2017/12/20
- [Qemu-trivial] [PATCH v6 01/29] audio: Replace AUDIO_FUNC with __func__, Alistair Francis, 2017/12/20
- [Qemu-trivial] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/12/20
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(),
Markus Armbruster <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(), Markus Armbruster, 2017/12/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(), Thomas Huth, 2017/12/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/12/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(), Markus Armbruster, 2017/12/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/12/22
[Qemu-trivial] [PATCH v6 06/29] hw/gpio: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/12/20
[Qemu-trivial] [PATCH v6 05/29] hw/dma: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/12/20
[Qemu-trivial] [PATCH v6 07/29] hw/i2c: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/12/20
[Qemu-trivial] [PATCH v6 02/29] Replace all occurances of __FUNCTION__ with __func__, Alistair Francis, 2017/12/20