[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCHv2] filter-mirror: segfault when specifying non

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCHv2] filter-mirror: segfault when specifying non existent device
Date: Mon, 16 Oct 2017 23:16:34 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

29.09.2017 15:03, Eduardo Otubo wrote:
> v2:
>     Removed "err:" label from the end of the function and replaced by
>     two separate error messages. One when outdev is not specified and
>     one when outdev does not exist.
>     Fixed the error message that was referencing nf->netdev_id and not
>     s->outdev.
> When using filter-mirror like the example below where the interface
> 'ndev0' does not exist on the host, QEMU crashes into segmentation
> fault.
>  $ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object 
> filter-mirror,id=test-object,netdev=ndev0
> This happens because the function filter_mirror_setup() does not checks
> if the device actually exists and still keep on processing calling
> qemu_chr_find(). This patch fixes this issue.

Applied to -trivial, with a tiny fix in the commit message (checkS).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]