qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused


From: Alistair Francis
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field
Date: Thu, 12 Oct 2017 09:36:59 -0700

On Thu, Oct 12, 2017 at 6:17 AM, Peter Maydell <address@hidden> wrote:
> The struct OrIRQState has an unused member field in_irqs.
> This is a legacy of earlier versions of the patch; the
> code that used it was dropped from the final version of
> the code that went into master, but we forgot to delete
> the no-longer-used struct field. Do so now.
>
> Signed-off-by: Peter Maydell <address@hidden>

Good catch.

Reviewed-by: Alistair Francis <address@hidden>

Thanks,
Alistair

> ---
>  include/hw/or-irq.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/or-irq.h b/include/hw/or-irq.h
> index d400a81..fd900fc 100644
> --- a/include/hw/or-irq.h
> +++ b/include/hw/or-irq.h
> @@ -38,7 +38,6 @@ struct OrIRQState {
>      DeviceState parent_obj;
>
>      qemu_irq out_irq;
> -    qemu_irq *in_irqs;
>      bool levels[MAX_OR_LINES];
>      uint16_t num_lines;
>  };
> --
> 2.7.4
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]