[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/88] use g_new() family of func
From: |
no-reply |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/88] use g_new() family of functions |
Date: |
Fri, 6 Oct 2017 18:27:06 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/88] use g_new() family of functions
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
c804c28ce1 scripts/coverity-model: use g_new() family of functions
b0e0658a5c hw/net/rocker: use g_new() family of functions
183562cc1d net/hub: use g_new() family of functions
b9f50bfa72 hw/usb: use g_new() family of functions
cff8a0d8e5 hw/scsi: use g_new() family of functions
071370df89 hw/pci: use g_new() family of functions
175fef7b9d hw/ipmi: use g_new() family of functions
5e8c9e184d hw/acpi: use g_new() family of functions
62ee9aea32 numa: use g_new() family of functions
57e59bd5a3 hmp: use g_new() family of functions
5736d72820 gdb: use g_new() family of functions
935c453c3e dump: use g_new() family of functions
fe6b9cd532 dma: use g_new() family of functions
b80633b250 decnumber: use g_new() family of functions
330df41ca1 balloon: use g_new() family of functions
599de671cb hw/block/xen_disk: avoid use of g_new0()
21bb36804a hw/block/nvme: use g_new() family of functions
06226f3349 block: avoid use of g_new0()
ac1388fadb block: use g_new() family of functions
15186d5c50 virtio-9p: use g_new() family of functions
4db380eabf virtio: use g_new() family of functions
3e7a3445ce util/coroutine: use g_new() family of functions
eb8027f518 util/qemu-thread-win32: use g_new() family of functions
6c3385656d util: use g_new() family of functions
d4fcc9cbd7 user: use g_strfreev()
27cbb7ecf7 bsd-user/syscall: fix a memory leak on EFAULT, use g_new()
603f6d2797 user: use g_new() family of functions
8952c25f5d tests: use g_new() family of functions
a76a1c1038 sPAPR: use g_new() family of functions
747d79335c ppce500: use g_new() family of functions
d6737387c5 ppc4xx: use g_new() family of functions
cc4e72bb73 ppc: use g_new() family of functions
f014ab5c23 PowerPC: use g_new() family of functions
1c7f285465 PReP: use g_new() family of functions
a89817ffbd KVM: use g_new() family of functions
62e9ee5d6d iSCSI: use g_new() family of functions
a5f0a975ad i.MX31: use g_new() family of functions
e3c99cd21c hw/timer: use g_new() family of functions
57b0cb6f00 ivshmem: use g_new() family of functions
ab0935ee66 hw/misc: use g_new() family of functions
51edcbd3d0 hw/input: use g_new() family of functions
c5a983b01b hw/i2c: use g_new() family of functions
3d2167e517 hw/display/vga: use g_new() family of functions
6700833717 hw/display: use g_new() family of functions
3b6e0a9ba0 hw/core/loader: use g_new() family of functions
397f1320a0 hw/core: use g_new() family of functions
7fc29ad15d XTFPGA: use g_new() family of functions
c9c7a78335 target/i386: use g_new() family of functions
dcf5c388df hw/xen: use g_new() family of functions
d359058b9c hw/i386: use g_new() family of functions
0f2bd5995e VFIO: use g_new() family of functions
6149f4936f TCG: use g_new() family of functions
2e7bd6ee2c SLIRP: use g_new() family of functions
48c3189a1e Record/replay: use g_new() family of functions
eb4526cfb0 qapi: use g_new() family of functions
317f58f9f2 qom: use g_new() family of functions
f7c8362449 QObject: use g_new() family of functions
61a83549f4 QMP: use g_new() family of functions
3979392544 QEMU Guest Agent: use g_new() family of functions
f00debd577 SPARC: use g_new() family of functions
eb7a298007 disas: use g_new() family of functions
859752d9e4 SH4: use g_new() family of functions
875e2fd57b S390: use g_new() family of functions
18b1a93522 OpenRISC: use g_new() family of functions
98fc4795cd MIPS: use g_new() family of functions
13bc92e683 M68K: use g_new() family of functions
94928b9ef3 LM32: use g_new() family of functions
6014b8ee35 NBD: use g_new() family of functions
3e69886310 Migration: use g_new() family of functions
8920e8ca87 exec: use g_new() family of functions
701099c16e memory: use g_new() family of functions
5f388075f6 Memory API: use g_new() family of functions
ccb604eee5 Main loop: use g_new() family of functions
c294183f4e ui/spice: use g_new() family of functions
9c876c33e2 ui/vnc: use g_new() family of functions
c943798f44 Dirty Bitmaps: use g_new() family of functions
a19287589f backends/hostmem: use g_new() family of functions
1fbf4bcb17 Cryptodev Backends: use g_new() family of functions
91e8adaa1e Character devices: use g_new() family of functions
970467d2d3 Bootdevice: use g_new() family of functions
debee4ea8b BT: use g_new() family of functions
94a157985c Audio: use g_new() family of functions
42db35f96b ARM: use g_new() family of functions
420a3342c4 cocci: use g_strfreev()
78845ef8df cocci: avoid use of g_new0()
f8c6a75cb5 cocci: extract typeof() from g_new()
97dbb2f234 cocci: add more g_new() transformations
8dbd9f91b4 cocci: script to use g_new() & friends
=== OUTPUT BEGIN ===
Checking PATCH 1/88: cocci: script to use g_new() & friends...
Checking PATCH 2/88: cocci: add more g_new() transformations...
Checking PATCH 3/88: cocci: extract typeof() from g_new()...
Checking PATCH 4/88: cocci: avoid use of g_new0()...
Checking PATCH 5/88: cocci: use g_strfreev()...
Checking PATCH 6/88: ARM: use g_new() family of functions...
Checking PATCH 7/88: Audio: use g_new() family of functions...
Checking PATCH 8/88: BT: use g_new() family of functions...
Checking PATCH 9/88: Bootdevice: use g_new() family of functions...
Checking PATCH 10/88: Character devices: use g_new() family of functions...
Checking PATCH 11/88: Cryptodev Backends: use g_new() family of functions...
Checking PATCH 12/88: backends/hostmem: use g_new() family of functions...
Checking PATCH 13/88: Dirty Bitmaps: use g_new() family of functions...
Checking PATCH 14/88: ui/vnc: use g_new() family of functions...
Checking PATCH 15/88: ui/spice: use g_new() family of functions...
Checking PATCH 16/88: Main loop: use g_new() family of functions...
Checking PATCH 17/88: Memory API: use g_new() family of functions...
Checking PATCH 18/88: memory: use g_new() family of functions...
Checking PATCH 19/88: exec: use g_new() family of functions...
Checking PATCH 20/88: Migration: use g_new() family of functions...
Checking PATCH 21/88: NBD: use g_new() family of functions...
Checking PATCH 22/88: LM32: use g_new() family of functions...
Checking PATCH 23/88: M68K: use g_new() family of functions...
Checking PATCH 24/88: MIPS: use g_new() family of functions...
Checking PATCH 25/88: OpenRISC: use g_new() family of functions...
Checking PATCH 26/88: S390: use g_new() family of functions...
Checking PATCH 27/88: SH4: use g_new() family of functions...
Checking PATCH 28/88: disas: use g_new() family of functions...
ERROR: code indent should never use tabs
#38: FILE: disas/nios2.c:2628:
+^I new_hash = g_new(nios2_opcode_hash, 1);$
total: 1 errors, 0 warnings, 27 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 29/88: SPARC: use g_new() family of functions...
Checking PATCH 30/88: QEMU Guest Agent: use g_new() family of functions...
Checking PATCH 31/88: QMP: use g_new() family of functions...
Checking PATCH 32/88: QObject: use g_new() family of functions...
Checking PATCH 33/88: qom: use g_new() family of functions...
Checking PATCH 34/88: qapi: use g_new() family of functions...
Checking PATCH 35/88: Record/replay: use g_new() family of functions...
Checking PATCH 36/88: SLIRP: use g_new() family of functions...
Checking PATCH 37/88: TCG: use g_new() family of functions...
Checking PATCH 38/88: VFIO: use g_new() family of functions...
WARNING: line over 80 characters
#176: FILE: hw/vfio/pci.c:1440:
+ vdev->msix->pending = g_new0(unsigned long,
BITS_TO_LONGS(vdev->msix->entries));
total: 0 errors, 1 warnings, 169 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 39/88: hw/i386: use g_new() family of functions...
Checking PATCH 40/88: hw/xen: use g_new() family of functions...
Checking PATCH 41/88: target/i386: use g_new() family of functions...
Checking PATCH 42/88: XTFPGA: use g_new() family of functions...
Checking PATCH 43/88: hw/core: use g_new() family of functions...
Checking PATCH 44/88: hw/core/loader: use g_new() family of functions...
Checking PATCH 45/88: hw/display: use g_new() family of functions...
Checking PATCH 46/88: hw/display/vga: use g_new() family of functions...
Checking PATCH 47/88: hw/i2c: use g_new() family of functions...
Checking PATCH 48/88: hw/input: use g_new() family of functions...
Checking PATCH 49/88: hw/misc: use g_new() family of functions...
Checking PATCH 50/88: ivshmem: use g_new() family of functions...
Checking PATCH 51/88: hw/timer: use g_new() family of functions...
Checking PATCH 52/88: i.MX31: use g_new() family of functions...
Checking PATCH 53/88: iSCSI: use g_new() family of functions...
Checking PATCH 54/88: KVM: use g_new() family of functions...
Checking PATCH 55/88: PReP: use g_new() family of functions...
Checking PATCH 56/88: PowerPC: use g_new() family of functions...
Checking PATCH 57/88: ppc: use g_new() family of functions...
Checking PATCH 58/88: ppc4xx: use g_new() family of functions...
Checking PATCH 59/88: ppce500: use g_new() family of functions...
Checking PATCH 60/88: sPAPR: use g_new() family of functions...
Checking PATCH 61/88: tests: use g_new() family of functions...
Checking PATCH 62/88: user: use g_new() family of functions...
Checking PATCH 63/88: bsd-user/syscall: fix a memory leak on EFAULT, use
g_new()...
Checking PATCH 64/88: user: use g_strfreev()...
Checking PATCH 65/88: util: use g_new() family of functions...
ERROR: code indent should never use tabs
#54: FILE: util/envlist.c:27:
+^Ienvlist = g_new(envlist_t, 1);$
ERROR: code indent should never use tabs
#63: FILE: util/envlist.c:161:
+^Ientry = g_new(struct envlist_entry, 1);$
ERROR: code indent should never use tabs
#72: FILE: util/envlist.c:221:
+^Ipenv = env = g_new(char *, envlist->el_count + 1);$
total: 3 errors, 0 warnings, 120 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 66/88: util/qemu-thread-win32: use g_new() family of functions...
Checking PATCH 67/88: util/coroutine: use g_new() family of functions...
Checking PATCH 68/88: virtio: use g_new() family of functions...
Checking PATCH 69/88: virtio-9p: use g_new() family of functions...
Checking PATCH 70/88: block: use g_new() family of functions...
Checking PATCH 71/88: block: avoid use of g_new0()...
Checking PATCH 72/88: hw/block/nvme: use g_new() family of functions...
Checking PATCH 73/88: hw/block/xen_disk: avoid use of g_new0()...
Checking PATCH 74/88: balloon: use g_new() family of functions...
Checking PATCH 75/88: decnumber: use g_new() family of functions...
ERROR: code indent should never use tabs
#21: FILE: libdecnumber/decNumber.c:4092:
+^Iallocacc=g_new(uint16_t, need);$
ERROR: spaces required around that '=' (ctx:VxV)
#21: FILE: libdecnumber/decNumber.c:4092:
+ allocacc=g_new(uint16_t, need);
^
ERROR: spaces required around that '=' (ctx:VxV)
#30: FILE: libdecnumber/decNumber.c:4455:
+ allocacc=g_new(uint16_t, acclength);
^
ERROR: spaces required around that '=' (ctx:VxV)
#39: FILE: libdecnumber/decNumber.c:4480:
+ varalloc=g_new(uint16_t, (var1units+1));
^
ERROR: spaces required around that '+' (ctx:VxV)
#39: FILE: libdecnumber/decNumber.c:4480:
+ varalloc=g_new(uint16_t, (var1units+1));
^
ERROR: spaces required around that '=' (ctx:VxV)
#48: FILE: libdecnumber/decNumber.c:6317:
+ allocacc=g_new(uint16_t, need);
^
total: 6 errors, 0 warnings, 32 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 76/88: dma: use g_new() family of functions...
ERROR: code indent should never use tabs
#45: FILE: hw/dma/etraxfs_dma.c:771:
+^Ictrl = g_new0(struct fs_dma_ctrl, 1);$
total: 1 errors, 0 warnings, 34 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 77/88: dump: use g_new() family of functions...
Checking PATCH 78/88: gdb: use g_new() family of functions...
Checking PATCH 79/88: hmp: use g_new() family of functions...
Checking PATCH 80/88: numa: use g_new() family of functions...
Checking PATCH 81/88: hw/acpi: use g_new() family of functions...
Checking PATCH 82/88: hw/ipmi: use g_new() family of functions...
Checking PATCH 83/88: hw/pci: use g_new() family of functions...
Checking PATCH 84/88: hw/scsi: use g_new() family of functions...
Checking PATCH 85/88: hw/usb: use g_new() family of functions...
Checking PATCH 86/88: net/hub: use g_new() family of functions...
Checking PATCH 87/88: hw/net/rocker: use g_new() family of functions...
Checking PATCH 88/88: scripts/coverity-model: use g_new() family of functions...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-trivial] [PATCH 81/88] hw/acpi: use g_new() family of functions, (continued)
- [Qemu-trivial] [PATCH 82/88] hw/ipmi: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-trivial] [PATCH 83/88] hw/pci: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-trivial] [PATCH 84/88] hw/scsi: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-trivial] [PATCH 85/88] hw/usb: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-trivial] [PATCH 86/88] net/hub: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-trivial] [PATCH 88/88] scripts/coverity-model: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-trivial] [PATCH 87/88] hw/net/rocker: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- Re: [Qemu-trivial] [PATCH 00/88] use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/88] use g_new() family of functions,
no-reply <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/88] use g_new() family of functions, no-reply, 2017/10/07
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/88] use g_new() family of functions, Peter Maydell, 2017/10/07