[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 09/29] vpc: use DIV_ROUND_UP
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 09/29] vpc: use DIV_ROUND_UP |
Date: |
Thu, 13 Jul 2017 15:20:21 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/13/2017 11:31 AM, Marc-André Lureau wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> block/vpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/vpc.c b/block/vpc.c
> index 9a6f8173a5..c88dc72491 100644
> --- a/block/vpc.c
> +++ b/block/vpc.c
> @@ -760,7 +760,7 @@ static int calculate_geometry(int64_t total_sectors,
> uint16_t* cyls,
> } else {
> *secs_per_cyl = 17;
> cyls_times_heads = total_sectors / *secs_per_cyl;
> - *heads = (cyls_times_heads + 1023) / 1024;
> + *heads = DIV_ROUND_UP(cyls_times_heads, 1024);
>
> if (*heads < 4) {
> *heads = 4;
> @@ -813,7 +813,7 @@ static int create_dynamic_disk(BlockBackend *blk, uint8_t
> *buf,
> offset = 3 * 512;
>
> memset(buf, 0xFF, 512);
> - for (i = 0; i < (num_bat_entries * 4 + 511) / 512; i++) {
> + for (i = 0; i < DIV_ROUND_UP(num_bat_entries * 4, 512); i++) {
> ret = blk_pwrite(blk, offset, buf, 512, 0);
> if (ret < 0) {
> goto fail;
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-trivial] [PATCH v2 05/29] i8254: use QEMU_ALIGN_DOWN, (continued)
- [Qemu-trivial] [PATCH v2 06/29] pcspk: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 07/29] dmg: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 08/29] qcow2: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 09/29] vpc: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 10/29] vvfat: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 11/29] vnc: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 12/29] ui: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-trivial] [PATCH v2 13/29] vga: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13