[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap

From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64
Date: Thu, 29 Jun 2017 18:52:57 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Am 29.06.2017 um 18:29 schrieb Eric Blake:
> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>> remove some copy/paste leftover, code seems sane.
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Double-sob seems odd.

Maybe that double SOB can be cleaned by qemu-trivial (cc'ed).

>> ---
>>  tcg/tci.c | 1 -
>>  1 file changed, 1 deletion(-)
> Otherwise,
> Reviewed-by: Eric Blake <address@hidden>

Note from the author: it's not a copy/paste leftover, but was
there on purpose: that code part was simply never executed
before, and I only removed the TODO() statements from tested

So you are the first one who found a test case. Congratulations.

Reviewed-by: Stefan Weil <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]