[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Handle having no c++

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check
Date: Mon, 26 Jun 2017 12:51:43 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 06/26/2017 12:25 PM, Peter Maydell wrote:
Our FORTIFY_SOURCE check assumes that $cxx refers to a working C++
compiler, with the result that if you don't happen to have one
then configure will spuriously print
   configure: line 4685: c++: command not found

Fix this by adding a 'has $cxx' check.

Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index c571ad1..a435908 100755
--- a/configure
+++ b/configure
@@ -4681,7 +4681,7 @@ fi
  if test "$fortify_source" != "no"; then
    if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
-  elif test -n "$cxx" &&
+  elif test -n "$cxx" && has $cxx &&
         echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then

reply via email to

[Prev in Thread] Current Thread [Next in Thread]