[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opa
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h |
Date: |
Thu, 22 Jun 2017 19:34:58 +0100 |
User-agent: |
Mutt/1.8.2 (2017-04-18) |
* Peter Maydell (address@hidden) wrote:
> On 22 June 2017 at 19:08, Thomas Huth <address@hidden> wrote:
> > On 22.06.2017 19:50, Dr. David Alan Gilbert wrote:
> >> Could do; I'm just not finding tiny header files with one or
> >> two entries each that useful.
>
> Well, it means that the bulk of code that doesn't care about the
> types doesn't get its compilation fractionally slowed by having
> to parse the typedef anyway. In general I think we're drifting
> towards "have each .c file get fewer things automatically" rather
> than otherwise (eg more finely focused files rather than stuffing
> everything into qemu-common.h).
At the cost of things getting fractionally slower by including lots
more tiny headers.
I generally agree in the case where there's a useful chunk,
but when it's down to one or two definitions I don't see the point.
> > Do we really need these function typedefs at all? IMHO it's quite ugly
> > to hide such things in a typedef unless it is really necessary (and in
> > this case, it does not seem to be really necessary since it is only used
> > in a few places). So what about simply removing the typedefs in this case?
>
> I find function typedefs much more readable than having the
> function-types inline in function arguments and the like.
>
> This is all fairly rapidly heading into bikeshed territory
> though -- in the final analysis I don't think it matters
> much what we do.
Agreed.
Dave
> thanks
> -- PMM
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Peter Maydell, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Juan Quintela, 2017/06/22
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Peter Maydell, 2017/06/22
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Thomas Huth, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Peter Maydell, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h,
Dr. David Alan Gilbert <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/26
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Markus Armbruster, 2017/06/23
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Juan Quintela, 2017/06/28
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Markus Armbruster, 2017/06/23