[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/cpu: core.c can be compiled as common obje
Re: [Qemu-trivial] [PATCH] hw/cpu: core.c can be compiled as common object
Fri, 9 Jun 2017 10:20:53 -0300
On Fri, Jun 09, 2017 at 12:03:38PM +1000, David Gibson wrote:
> On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote:
> > Thomas Huth <address@hidden> wrote:
> > > There does not seem to be any target specific code in core.c, so we can
> > > put it into "common-obj" instead of "obj" to compile it only once for
> > > all targets.
> > >
> > > Signed-off-by: Thomas Huth <address@hidden>
> > It compiles.
> > I can't see anything that is target dependent on core.c.
> > So
> > Reviewed-by: Juan Quintela <address@hidden>
> I've merged this into my ppc-for-2.10 tree, on the basis that ppc is
> the only user of core.c so far. Any objections?
No problem to me. If you want, you can add my:
Acked-by: Eduardo Habkost <address@hidden>