[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Detect native NetBSD

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Detect native NetBSD curses(3)
Date: Sat, 20 May 2017 20:35:59 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Hi Kamil,

On 04/26/2017 07:50 AM, Kamil Rytarowski wrote:
NetBSD ships with traditional BSD curses with compatibility with ncurses.
qemu works nicely with the basesystem version of curses(3) from NetBSD.

The only mismatch between curses(3) and ncurses is the lack of
curses_version() in the NetBSD version. This function is used solely in
the configure script, therefore eliminate it from the curses(3) detection.

With this change applied, configure detects correctly curses frontend.

Signed-off-by: Kamil Rytarowski <address@hidden>
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/configure b/configure
index c35acf1192..17dc7224f7 100755
--- a/configure
+++ b/configure
@@ -3034,14 +3034,13 @@ if test "$curses" != "no" ; then
 #include <curses.h>

This checks if the <curses.h> include in present,

 #include <wchar.h>
 int main(void) {
-  const char *s = curses_version();

This however checks if the library is present, trying to link it.

   wchar_t wch = L'w';
   setlocale(LC_ALL, "");
   resize_term(0, 0);
   addwstr(L"wide chars\n");
   addnwstr(&wch, 1);

Those 3 functions also belong to the libcurse, so the link is still checked, and this patch looks good to me.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

-  return s != 0;
+  return 0;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]