[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue |
|
Date: |
Tue, 25 Apr 2017 08:54:27 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/25/2017 08:50 AM, Kamil Rytarowski wrote:
> On 25.04.2017 15:33, Peter Maydell wrote:
>> On 25 April 2017 at 14:18, Kamil Rytarowski <address@hidden> wrote:
>>> Appease pkgsrc and use portable shell variable comparison.
>>> This switches "==" to "=". It should not be a functional change.
>>>
>>> Signed-off-by: Kamil Rytarowski <address@hidden>
>>> ---
>>
>> Thanks for this patch; it's an easy bug to let slip in
>> if your /bin/sh happens to be bash.
>>
>> PS: you forgot to cc qemu-devel@ on this patch.
>>
>
> I assumed that qemu-trivial@ don't need to go to address@hidden Thank you
> for pointing it out.
ALL patches need to go to qemu-devel (so we have a one-stop-shop for all
pending patches), but some patches need to additionally go to secondary
lists for catching the attention of the right maintainers.
scripts/get_maintainer.pl is your friend, and it should always list
qemu-devel in its answer.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature