[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 1/2] virtio-blk: Remove useless condition arou
Re: [Qemu-trivial] [PATCH 1/2] virtio-blk: Remove useless condition around g_free()
Sun, 23 Apr 2017 20:30:17 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
07.02.2017 16:27, Fam Zheng wrote:
> Laszlo spotted and studied this wasteful "if". He pointed out:
> The original virtio_blk_free_request needed an "if" as it accesses one
> field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to
> pointer", 2014-06-11); later on in f897bf751fbd ("virtio-blk: embed
> VirtQueueElement in VirtIOBlockReq", 2014-07-09) the field became
> embedded, so the "if" became unnecessary (at which point we were using
> g_slice_free(), but it is the same.
> Now drop it.
Applied to -trivial, thanks!
|[Prev in Thread]
||[Next in Thread]|
- Re: [Qemu-trivial] [PATCH 1/2] virtio-blk: Remove useless condition around g_free(),
Michael Tokarev <=