[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3] SGABIOS: fix wrong video attrs for int 10h
Re: [Qemu-trivial] [PATCH v3] SGABIOS: fix wrong video attrs for int 10h, ah==13h
Sun, 23 Apr 2017 12:03:45 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
10.03.2017 18:54, Herbie Robinson wrote:
> Fix Bug #1670509: wrong video attrs for int 10h, ah==13h
> The subroutine set_cursor_position is trashing %bx.
> Unfortunately, %bl contains the video attribute for write_string.
> The fix saves %bx in the function prolog and restores it in
> the epilog.
> Signed-off-by: Herbie Robinson <address@hidden>
> Removed incorrect code deletions from set_current_cursor.
> Removed explanation of same from the commit message.
> BTW, I didn't see any test cases for this code, but if they exist
> and somebody points me at them, I should be able to generate a
> very small qcow2 file that demonstrates the problem.
> sgabios.S | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/sgabios.S b/sgabios.S
Now I'm not quite sure what to do with this.
It is part of sgabios, which is not qemu code but a submodule.
Maybe it's better to apply it upstream?
Or should we apply it directly?
|[Prev in Thread]
||[Next in Thread]|
- Re: [Qemu-trivial] [PATCH v3] SGABIOS: fix wrong video attrs for int 10h, ah==13h,
Michael Tokarev <=