[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Removed trailing newline from er
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Removed trailing newline from error_report()
Mon, 10 Apr 2017 11:22:54 +0100
On Sat, Apr 08, 2017 at 11:09:47AM +0530, Ishani Chugh wrote:
> Signed-off-by: Ishani Chugh <address@hidden>
> target/arm/kvm64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for the patch!
I have CCed Peter Maydell who maintains this source file. I also added
the trivial patches mailing list - a patch queue for small patches.
Conventially QEMU commit messages are written like this:
target-arm: remove trailing newline from error_report()
The "target-arm:" prefix names the subsystem that is affected. It makes
it easier for maintainer or people searching through patches to find
The commit message is written in the present imperative - "remove X"
instead of "removed X".
You do not need to resend the patch. The maintainer can fix up the
commit message if they like.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Description: PGP signature
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Removed trailing newline from error_report(),
Stefan Hajnoczi <=