Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 06/14] sm501: Add missing arbitration control register

[Peter Maydell]

On 2 March 2017 at 20:08, Peter Maydell <address@hidden> wrote:
> On 3 December 2016 at 15:32, BALATON Zoltan <address@hidden> wrote:
>> Signed-off-by: BALATON Zoltan <address@hidden>
>> ---
>>  hw/display/sm501.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
>> index d9219bd..b977094 100644
>> --- a/hw/display/sm501.c
>> +++ b/hw/display/sm501.c
>> @@ -477,6 +477,7 @@ typedef struct SM501State {
>>      uint32_t gpio_31_0_control;
>>      uint32_t gpio_63_32_control;
>>      uint32_t dram_control;
>> +    uint32_t arbitration_control;
>>      uint32_t irq_mask;
>>      uint32_t misc_timing;
>>      uint32_t power_mode_control;
>> @@ -760,6 +761,9 @@ static uint64_t sm501_system_config_read(void *opaque, 
>> hwaddr addr,
>>      case SM501_DRAM_CONTROL:
>>          ret = (s->dram_control & 0x07F107C0) | s->local_mem_size_index << 
>> 13;
>>          break;
>> +    case SM501_ARBTRTN_CONTROL:
>> +        ret = s->arbitration_control;
>> +        break;
>>      case SM501_IRQ_MASK:
>>          ret = s->irq_mask;
>>          break;
>> @@ -812,6 +816,9 @@ static void sm501_system_config_write(void *opaque, 
>> hwaddr addr,
>>          /* TODO : check validity of size change */
>>          s->dram_control |=  value & 0x7FFFFFC3;
>>          break;
>> +    case SM501_ARBTRTN_CONTROL:
>> +        s->arbitration_control =  value & 0x37777777;
>> +        break;
>>      case SM501_IRQ_MASK:
>>          s->irq_mask = value;
>>          break;
>> --
>> 2.7.4
>
> Applied, thanks.

Doh, wrong canned-email-reply template! I meant

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM