[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/isa/isa-bus: Set category of
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/isa/isa-bus: Set category of the "isabus-bridge" device
Tue, 24 Jan 2017 10:27:35 +0100
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
Thomas Huth <address@hidden> writes:
> On 24.01.2017 08:42, Michael Tokarev wrote:
>> 20.01.2017 18:53, Thomas Huth wrote:
>>> It has "bridge" in its name, so it should be in the category
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> hw/isa/isa-bus.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
>>> index 9d07b11..0ffbc8d 100644
>>> --- a/hw/isa/isa-bus.c
>>> +++ b/hw/isa/isa-bus.c
>>> @@ -219,6 +219,7 @@ static void isabus_bridge_class_init(ObjectClass
>>> *klass, void *data)
>>> DeviceClass *dc = DEVICE_CLASS(klass);
>>> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>>> dc->fw_name = "isa";
>> Does it have any effect on the guest?
>> ISA is an old thing...
> No, as far as I know, this is just used in qdev_print_devinfos() to
> print out the devices in nice categories when you start QEMU with
> "-device ?". Devices that do not have a category bit set show up in the
> "Uncategorized" section - which tends to get overcrowded if the devices
> are not sorted into proper categories.
It's definitely the only effect of dc->categories.
Reviewed-by: Markus Armbruster <address@hidden>