[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report sta
From: |
Thomas Huth |
Subject: |
Re: [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements |
Date: |
Wed, 18 Jan 2017 09:05:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 18.01.2017 09:03, Ziyue Yang wrote:
> From: Ziyue Yang <address@hidden>
>
> Some updates from fprintf(stderr, ...) to error_report.
>
> Signed-off-by: Ziyue Yang <address@hidden>
> ---
> gdbstub.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 426d55e..959f6dc 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -637,8 +637,8 @@ void gdb_register_coprocessor(CPUState *cpu,
> *p = s;
> if (g_pos) {
> if (g_pos != s->base_reg) {
> - fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n"
> - "Expected %d got %d\n", xml, g_pos, s->base_reg);
> + error_report("Error: Bad gdb register numbering for '%s', "
> + "expected %d got %d", xml, g_pos, s->base_reg);
> } else {
> cpu->gdb_num_g_regs = cpu->gdb_num_regs;
> }
> @@ -890,7 +890,7 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> }
> case 'k':
> /* Kill the target */
> - fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
> + error_report("QEMU: Terminated via GDBstub");
> exit(0);
> case 'D':
> /* Detach packet */
> @@ -1358,8 +1358,8 @@ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const
> char *fmt, va_list va)
> break;
> default:
> bad_format:
> - fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n",
> - fmt - 1);
> + error_report("gdbstub: Bad syscall format string '%s'",
> + fmt - 1);
> break;
> }
> } else {
> --
> 2.7.4
Reviewed-by: Thomas Huth <address@hidden>