qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] vl.c: move pidfile creation up


From: Michael Tokarev
Subject: [Qemu-trivial] [PATCH] vl.c: move pidfile creation up
Date: Sat, 29 Oct 2016 11:07:42 +0300

With current code, pid file is open after various
sockets, chardevs, fsdevs and the like.  This causes
interesting effects, for example when monitor is a
unix-socket, and another qemu instance is already
running, new qemu first "damages" the socket and
next complain that it can't acquire the pid file and
exits, making running qemu unreachable.

Move pid file creation a bit earlier.

Signed-off-by: Michael Tokarev <address@hidden>
---
 vl.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/vl.c b/vl.c
index 55763f7..7989f75 100644
--- a/vl.c
+++ b/vl.c
@@ -4305,6 +4305,11 @@ int main(int argc, char **argv, char **envp)
         exit(1);
     }
 
+    if (pid_file && qemu_create_pidfile(pid_file) != 0) {
+        error_report("could not acquire pid file: %s", strerror(errno));
+        exit(1);
+    }
+
     page_size_init();
     socket_init();
 
@@ -4326,11 +4331,6 @@ int main(int argc, char **argv, char **envp)
     }
 #endif
 
-    if (pid_file && qemu_create_pidfile(pid_file) != 0) {
-        error_report("could not acquire pid file: %s", strerror(errno));
-        exit(1);
-    }
-
     if (qemu_opts_foreach(qemu_find_opts("device"),
                           device_help_func, NULL, NULL)) {
         exit(0);
-- 
2.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]