[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] char: fix missing return in erro

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] char: fix missing return in error path for chardev TLS init
Date: Fri, 30 Sep 2016 10:47:26 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/30/2016 10:02 AM, Daniel P. Berrange wrote:
> If the qio_channel_tls_new_(server|client) methods fail,
> we disconnect the client. Unfortunately a missing return
> means we then go on to try and run the TLS handshake on
> a NULL I/O channel. This gives predictably segfaulty
> results.
> The main way to trigger this is to request a bogus TLS
> priority string for the TLS credentials. e.g.
>   -object tls-creds-x509,id=tls0,priority=wibble,...
> Most other ways appear impossible to trigger except
> perhaps if OOM conditions cause gnutls initialization
> to fail.
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  qemu-char.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]