[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCHv2] m68k: change default system cl

From: Greg Ungerer
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCHv2] m68k: change default system clock for m5208evb
Date: Thu, 29 Sep 2016 22:39:55 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

Hi Thomas,

On 29/09/16 17:56, Thomas Huth wrote:
On 29.09.2016 09:50, Laurent Vivier wrote:

Le 28/09/2016 à 02:06, Greg Ungerer a écrit :
The shipping default setting for the Freescale M5208EVB board is to run
the CPU at 166.67MHz. The current qemu emulation code for this board is
defaulting to 66MHz. This results in time appearing to run way to slowly.
So a "sleep 5" in a standard ColdFire Linux build takes almost 15
seconds in real time to actually complete.

Change the hard coded default to match the default hardware setting.

Signed-off-by: Greg Ungerer <address@hidden>

This solution is as good as another, so:

Reviewed-by: Laurent Vivier <address@hidden>

Fine for me, too, so:

Reviewed-by: Thomas Huth <address@hidden>

Thanks for the review.


By the way, we still do not have a m68k maintainer yet ... Laurent,
maybe you could finally send a pull request for that patch here:
https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00805.html ?

Meanwhile, Peter, could you please take this patch here from Greg
directly? Or should it go via qemu-trivial instead?


 hw/m68k/mcf5208.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v2: more accurately set frequency (166666666 instead of 166000000)

diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
index 9240ebf..3438314 100644
--- a/hw/m68k/mcf5208.c
+++ b/hw/m68k/mcf5208.c
@@ -21,7 +21,7 @@
 #include "elf.h"
 #include "exec/address-spaces.h"

-#define SYS_FREQ 66000000
+#define SYS_FREQ 166666666

 #define PCSR_EN         0x0001
 #define PCSR_RLD        0x0002

reply via email to

[Prev in Thread] Current Thread [Next in Thread]