[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.
Date: Wed, 14 Sep 2016 10:30:07 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0

03.05.2016 04:10, Christopher Friedt wrote:
Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails to build for a 
few reasons.

One of those reasons is that Apple's ld (at least ld64) does not properly 
process archive files created with ar (even Apple's ar).

After some RTFM'ing, I came upon this tidbit, which is unfortunate. Luckily, 
autotools packages are not broken.

"Libtool with -static is intended to replace ar(5) and ranlib."

In any case, this change takes Apple's recommendations into account and allows 
Qemu to build on Mac OS X El Capitan.

Signed-off-by: Christopher Friedt <address@hidden>
 rules.mak | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/rules.mak b/rules.mak
index d1ff311..44421af 100644
--- a/rules.mak
+++ b/rules.mak
@@ -105,7 +105,11 @@ modules:
        $(call LINK,$(filter %.o %.a %.mo, $^))

+       $(call quiet-command,rm -f $@ && libtool -static -o $@ $^,"  libtool    
        $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,"  AR    

 quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))

Hmm.  Is this patch still relevant?  Apparently I missed it back then.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]