[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes
Date: Fri, 27 Nov 2015 18:42:07 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> On 27/11/2015 18:08, Markus Armbruster wrote:
>>> > evt_encrypt_change                     4      5
>> Used in bt_hci_event_encrypt_change().  I figure it makes bt_hci_event()
>> overrun the destination by one byte.
> Yes, and Coverity complains.
>> Kernel has
>>     struct hci_ev_encrypt_change {
>>             __u8     status;
>>             __le16   handle;
>>             __u8     encrypt;
>>     } __packed;
>> You changed this one.  Plausible, but I don't want to have my R-by on it
>> all the same.
> Shall I proceed with this patch, just without R-by?  Or only modify the
> one where Coverity complains?  I picked this one because it matches a
> bluez patch.

Yes, that seems to make the most sense.  If you feel like it, add a
sentence or two on the ones you don't fix to the commit message.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]