qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous


From: Thomas Huth
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements
Date: Wed, 11 Nov 2015 14:29:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/11/15 12:25, Cornelia Huck wrote:
> On Tue, 10 Nov 2015 21:16:10 +0100
> Thomas Huth <address@hidden> wrote:
> 
>> The "return;" statements at the end of functions do not make
>> much sense, so let's remove them.
>>
>> Cc: Cornelia Huck <address@hidden>
>> Cc: Christian Borntraeger <address@hidden>
>> Cc: Alexander Graf <address@hidden>
>> Cc: Richard Henderson <address@hidden>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  hw/s390x/css.c            |  1 -
>>  hw/s390x/event-facility.c | 21 ++++++---------------
>>  hw/s390x/s390-pci-bus.c   |  4 ----
>>  3 files changed, 6 insertions(+), 20 deletions(-)
>>
> 
> Ack for the css and pci parts.
> 
> The sclp parts, however, switch from "one point of exit" to "immediate
> exit", and I'm not sure I like that; not sure enough anyway to apply
> this patch.

Ah, right, I remember, you're prefering gotos ... well, no, I won't
start a discussion about that here again ;-) ... so feel free to remove
these hunks or simply ignore the patch completely.

 Cheers,
  Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]