[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Remove the definitio

From: Wei Huang
Subject: Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Remove the definition of NUM_CPU
Date: Thu, 5 Nov 2015 11:22:45 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 11/05/2015 11:13 AM, Andreas Färber wrote:
> Am 05.11.2015 um 18:11 schrieb Wei Huang:
>> arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu.
>> Such mixed-uses make source code inconsistent. This patch removes
>> NUM_CPU(s), which was defined for MPCore tweak long ago, and instead
>> favors s->num_cpu. The source is more consistent after this tweak.
>> Signed-off-by: Wei Huang <address@hidden>
>> ---
>>  hw/intc/arm_gic.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
> I don't mind either way, and it'll go through Peter's queue I guess,
> Reviewed-by: Andreas Färber <address@hidden>

Thanks. I sent out a wrong file which failed the compilation. So please
ignore this file.

Yeah, maybe through Peter's tree given that he is the maintainer of this


> Cheers,
> Andreas

reply via email to

[Prev in Thread] Current Thread [Next in Thread]