[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 46/47] gdbstub: avoid possible NULL pointer derefer
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 46/47] gdbstub: avoid possible NULL pointer dereference |
Date: |
Wed, 4 Mar 2015 20:07:03 +0300 |
From: Paolo Bonzini <address@hidden>
Coverity reports that s->chr is checked after put_packet dereferences it.
Move the check earlier, consistent with the code used for user-mode
emulation.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
gdbstub.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index e4a1a79..8abcb8a 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1443,15 +1443,17 @@ void gdb_exit(CPUArchState *env, int code)
if (gdbserver_fd < 0 || s->fd < 0) {
return;
}
+#else
+ if (!s->chr) {
+ return;
+ }
#endif
snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code);
put_packet(s, buf);
#ifndef CONFIG_USER_ONLY
- if (s->chr) {
- qemu_chr_delete(s->chr);
- }
+ qemu_chr_delete(s->chr);
#endif
}
--
2.1.4
- [Qemu-trivial] [PULL 39/47] disas/arm: Fix warnings caused by missing 'static' attribute, (continued)
- [Qemu-trivial] [PULL 39/47] disas/arm: Fix warnings caused by missing 'static' attribute, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 10/47] qerror.h: Swap definitions that were not in alphabetical order, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 15/47] numa: remove superfluous '\n' around error_setg, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 36/47] gitignore: Ignore new tests, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 06/47] migration/rdma: clean up qemu_rdma_dest_init a bit, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 25/47] xen: Remove xen_cmos_set_s3_resume(), Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 37/47] e500: fix memory leak, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 32/47] milkymist.c: fix memory leak, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 27/47] qemu-char: add cyrillic characters 'numerosign' to VNC keysyms, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 46/47] gdbstub: avoid possible NULL pointer dereference,
Michael Tokarev <=
- [Qemu-trivial] [PULL 11/47] qmp-commands.hx: Fix several typos, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 03/47] xilinx_ethlite: Clean up after commit 2f991ad, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 47/47] 9pfs: remove useless return, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 08/47] cutils: refine strtol error handling in parse_debug_env, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 28/47] qemu-char: add cyrillic key 'numerosign' to Russian keymap, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 13/47] a9gtimer: remove superfluous '\n' around error_setg, Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 43/47] migration: Fix coding style (whitespace issues), Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 16/47] Remove superfluous '\n' around error_report(), Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 21/47] arm/digic_boards: Remove superfluous '\n' around error_report(), Michael Tokarev, 2015/03/04
- [Qemu-trivial] [PULL 09/47] Add copyright and author after file split, Michael Tokarev, 2015/03/04