[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] gdbstub: avoid possible NULL pointer dereference
From: |
Paolo Bonzini |
Subject: |
[Qemu-trivial] [PATCH] gdbstub: avoid possible NULL pointer dereference |
Date: |
Mon, 2 Mar 2015 13:26:58 +0100 |
Coverity reports that s->chr is checked after put_packet dereferences it.
Move the check earlier, consistent with the code used for user-mode
emulation.
Signed-off-by: Paolo Bonzini <address@hidden>
---
gdbstub.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index e4a1a79..8abcb8a 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1443,15 +1443,17 @@ void gdb_exit(CPUArchState *env, int code)
if (gdbserver_fd < 0 || s->fd < 0) {
return;
}
+#else
+ if (!s->chr) {
+ return;
+ }
#endif
snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code);
put_packet(s, buf);
#ifndef CONFIG_USER_ONLY
- if (s->chr) {
- qemu_chr_delete(s->chr);
- }
+ qemu_chr_delete(s->chr);
#endif
}
--
2.3.0
- [Qemu-trivial] [PATCH] gdbstub: avoid possible NULL pointer dereference,
Paolo Bonzini <=