[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH RFC 4/5] pci-assign: Avoid qerror
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH RFC 4/5] pci-assign: Avoid qerror_report_err() outside QMP command handlers |
Date: |
Mon, 02 Mar 2015 11:14:20 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
zhanghailiang <address@hidden> writes:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in assigned_initfn().
>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
> hw/i386/kvm/pci-assign.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index bd92c69..f2f4e07 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -1831,8 +1831,7 @@ out:
>
> exit_with_error:
> assert(local_err);
> - qerror_report_err(local_err);
> - error_free(local_err);
> + error_report_err(local_err);
> return -1;
> }
This breaks the error reply when you hot plug the devices via QMP
device_add.
A correct solution is my "[PATCH 10/10] pci-assign: Convert to realize".
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [Qemu-devel] [PATCH RFC 4/5] pci-assign: Avoid qerror_report_err() outside QMP command handlers,
Markus Armbruster <=