[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluou
From: |
Gonglei |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg |
Date: |
Thu, 12 Feb 2015 09:10:54 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/2/11 21:41, Markus Armbruster wrote:
> <address@hidden> writes:
>
>> From: Gonglei <address@hidden>
>>
>> Yesterday, I found that some files have superfluous '\n' character
>> around error_report/error_setg when reviewed patches.
>>
>> By a simply script, the below files were listed. Classify and fix
>> them. It's suitable for applying via qemu-trivial IMHO.
>
> You can find my script in commit 312fd5f :)
>
It's cool, I haven't noticed it before. :)
>> Gonglei (11):
>> block: remove superfluous '\n' around error_report/error_setg
>> a9gtimer: remove superfluous '\n' around error_setg
>> pl330.c: remove superfluous '\n' around error_setg
>> numa: remove superfluous '\n' around error_setg
>> Remove superfluous '\n' around error_report()
>> vhost-scsi: Remove superfluous '\n' around error_report()
>> vfio: Remove superfluous '\n' around error_report()
>> xtensa: Remove superfluous '\n' around error_report()
>> tpm: Remove superfluous '\n' around error_report()
>> arm/digic_boards: Remove superfluous '\n' around error_report()
>> vhost: Remove superfluous '\n' around error_report()
>
> When I fixed this before, I didn't split it up (commits 312fd5f 6daf194
> be62a2eb). Splitting it up is fine, of course. Having the catch-all as
> PATCH 05/11 is a bit odd, though. Its qemu-img.c hunk could go into
> PATCH 01, because qemu-img is part of the block subsystem. Not worth a
> respin as far as I'm concerned.
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
Thanks.
Regards,
-Gonglei
- [Qemu-trivial] [PATCH 09/11] tpm: Remove superfluous '\n' around error_report(), (continued)
- [Qemu-trivial] [PATCH 09/11] tpm: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 10/11] arm/digic_boards: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 08/11] xtensa: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 07/11] vfio: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 04/11] numa: remove superfluous '\n' around error_setg, arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 01/11] block: remove superfluous '\n' around error_report/error_setg, arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 02/11] a9gtimer: remove superfluous '\n' around error_setg, arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 11/11] vhost: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- [Qemu-trivial] [PATCH 06/11] vhost-scsi: Remove superfluous '\n' around error_report(), arei.gonglei, 2015/02/10
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg, Markus Armbruster, 2015/02/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg,
Gonglei <=