[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 06/10] serial: Fix warnings caused by missing 'sta
From: |
Stefan Weil |
Subject: |
[Qemu-trivial] [PATCH 06/10] serial: Fix warnings caused by missing 'static' attribute |
Date: |
Fri, 6 Feb 2015 22:43:13 +0100 |
Warnings from the Sparse static analysis tool:
hw/char/serial.c:630:26: warning: symbol
'vmstate_serial_thr_ipending' was not declared. Should it be static?
hw/char/serial.c:646:26: warning: symbol
'vmstate_serial_tsr' was not declared. Should it be static?
hw/char/serial.c:665:26: warning: symbol
'vmstate_serial_recv_fifo' was not declared. Should it be static?
hw/char/serial.c:681:26: warning: symbol
'vmstate_serial_xmit_fifo' was not declared. Should it be static?
hw/char/serial.c:697:26: warning: symbol
'vmstate_serial_fifo_timeout_timer' was not declared. Should it be static?
hw/char/serial.c:713:26: warning: symbol
'vmstate_serial_timeout_ipending' was not declared. Should it be static?
hw/char/serial.c:729:26: warning: symbol
'vmstate_serial_poll' was not declared. Should it be static?
Signed-off-by: Stefan Weil <address@hidden>
---
hw/char/serial.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index bd25c03..0491897 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -658,7 +658,7 @@ static bool serial_thr_ipending_needed(void *opaque)
}
}
-const VMStateDescription vmstate_serial_thr_ipending = {
+static const VMStateDescription vmstate_serial_thr_ipending = {
.name = "serial/thr_ipending",
.version_id = 1,
.minimum_version_id = 1,
@@ -674,7 +674,7 @@ static bool serial_tsr_needed(void *opaque)
return s->tsr_retry != 0;
}
-const VMStateDescription vmstate_serial_tsr = {
+static const VMStateDescription vmstate_serial_tsr = {
.name = "serial/tsr",
.version_id = 1,
.minimum_version_id = 1,
@@ -693,7 +693,7 @@ static bool serial_recv_fifo_needed(void *opaque)
}
-const VMStateDescription vmstate_serial_recv_fifo = {
+static const VMStateDescription vmstate_serial_recv_fifo = {
.name = "serial/recv_fifo",
.version_id = 1,
.minimum_version_id = 1,
@@ -709,7 +709,7 @@ static bool serial_xmit_fifo_needed(void *opaque)
return !fifo8_is_empty(&s->xmit_fifo);
}
-const VMStateDescription vmstate_serial_xmit_fifo = {
+static const VMStateDescription vmstate_serial_xmit_fifo = {
.name = "serial/xmit_fifo",
.version_id = 1,
.minimum_version_id = 1,
@@ -725,7 +725,7 @@ static bool serial_fifo_timeout_timer_needed(void *opaque)
return timer_pending(s->fifo_timeout_timer);
}
-const VMStateDescription vmstate_serial_fifo_timeout_timer = {
+static const VMStateDescription vmstate_serial_fifo_timeout_timer = {
.name = "serial/fifo_timeout_timer",
.version_id = 1,
.minimum_version_id = 1,
@@ -741,7 +741,7 @@ static bool serial_timeout_ipending_needed(void *opaque)
return s->timeout_ipending != 0;
}
-const VMStateDescription vmstate_serial_timeout_ipending = {
+static const VMStateDescription vmstate_serial_timeout_ipending = {
.name = "serial/timeout_ipending",
.version_id = 1,
.minimum_version_id = 1,
@@ -757,7 +757,7 @@ static bool serial_poll_needed(void *opaque)
return s->poll_msl >= 0;
}
-const VMStateDescription vmstate_serial_poll = {
+static const VMStateDescription vmstate_serial_poll = {
.name = "serial/poll",
.version_id = 1,
.minimum_version_id = 1,
--
2.1.4
- [Qemu-trivial] [PATCH 00/10] Fix warnings (undeclared global symbols), Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 01/10] disas/cris: Fix warning caused by missing 'static' attribute, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 07/10] spice: Add missing 'static' attribute, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 09/10] vga: Fix warning caused by missing 'static' attribute, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 06/10] serial: Fix warnings caused by missing 'static' attribute,
Stefan Weil <=
- [Qemu-trivial] [PATCH 05/10] moxie: Fix warning caused by missing include statement, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 08/10] stubs: Fix warning caused by missing include statement, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 03/10] migration: Fix warning caused by missing declaration of vmstate_dummy, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 02/10] disas/sh4: Fix warning caused by missing 'static' attribute, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 10/10] virtio: Fix warning caused by missing 'static' attribute, Stefan Weil, 2015/02/06
- [Qemu-trivial] [PATCH 04/10] migration: Fix warnings caused by missing 'static' attribute, Stefan Weil, 2015/02/06
- Re: [Qemu-trivial] [PATCH 00/10] Fix warnings (undeclared global symbols), Michael Tokarev, 2015/02/08