Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

[Peter Maydell]

On 23 January 2015 at 10:07, Chen Gang S <address@hidden> wrote:
> It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the
> len.
>
> Signed-off-by: Chen Gang <address@hidden>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a66c2ae..8260ed7 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1896,7 +1896,7 @@ static void unlock_iovec(struct iovec *vec, abi_ulong 
> target_addr,
>      if (target_vec) {
>          for (i = 0; i < count; i++) {
>              abi_ulong base = tswapal(target_vec[i].iov_base);
> -            abi_long len = tswapal(target_vec[i].iov_base);
> +            abi_long len = tswapal(target_vec[i].iov_len);
>              if (len < 0) {
>                  break;
>              }
> --
> 1.9.3 (Apple Git-50)

Nice catch.
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM