[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 5/9] nvme: remove superfluous che
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check |
Date: |
Mon, 17 Nov 2014 16:55:50 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Nov 15, 2014 at 06:06:44PM +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
> ((n->bar.aqa >> AQA_ASQS_SHIFT) & AQA_ASQS_MASK) > 4095
> is always false regardless of the values of its operands.
> This occurs as the logical second operand of '||'.
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> hw/block/nvme.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpWMu8wzQGgW.pgp
Description: PGP signature
- [Qemu-trivial] [PATCH 0/9] Fix Coverity warning reports, arei.gonglei, 2014/11/15
- [Qemu-trivial] [PATCH 7/9] qemu-char: fix MISSING_COMMA, arei.gonglei, 2014/11/15
- [Qemu-trivial] [PATCH 5/9] nvme: remove superfluous check, arei.gonglei, 2014/11/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check,
Stefan Hajnoczi <=
- [Qemu-trivial] [PATCH 4/9] loader: fix NEGATIVE_RETURNS, arei.gonglei, 2014/11/15
- [Qemu-trivial] [PATCH 3/9] qga: fix false negative argument passing, arei.gonglei, 2014/11/15
- [Qemu-trivial] [PATCH 1/9] l2tpv3: fix fd leak, arei.gonglei, 2014/11/15
- [Qemu-trivial] [PATCH 2/9] mips_mipssim: fix use-after-free for filename, arei.gonglei, 2014/11/15
- [Qemu-trivial] [PATCH 6/9] acl: fix memory leak, arei.gonglei, 2014/11/15