[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH v5 5/8] don't use 'Yoda conditions'
From: |
arei.gonglei |
Subject: |
[Qemu-trivial] [PATCH v5 5/8] don't use 'Yoda conditions' |
Date: |
Mon, 11 Aug 2014 21:00:55 +0800 |
From: Gonglei <address@hidden>
imitate nearby code about using '!value' or 'value == NULL'
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qdev-monitor.c | 2 +-
qemu-char.c | 2 +-
util/qemu-sockets.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index f87f3d8..81a4e9b 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -694,7 +694,7 @@ void qmp_device_del(const char *id, Error **errp)
DeviceState *dev;
dev = qdev_find_recursive(sysbus_get_default(), id);
- if (NULL == dev) {
+ if (!dev) {
error_set(errp, QERR_DEVICE_NOT_FOUND, id);
return;
}
diff --git a/qemu-char.c b/qemu-char.c
index 6964a2d..3dcc39a 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -4121,7 +4121,7 @@ void qmp_chardev_remove(const char *id, Error **errp)
CharDriverState *chr;
chr = qemu_chr_find(id);
- if (NULL == chr) {
+ if (chr == NULL) {
error_setg(errp, "Chardev '%s' not found", id);
return;
}
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 74cf078..5d38395 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -732,7 +732,7 @@ int unix_connect_opts(QemuOpts *opts, Error **errp,
ConnectState *connect_state = NULL;
int sock, rc;
- if (NULL == path) {
+ if (path == NULL) {
error_setg(errp, "unix connect: no path specified");
return -1;
}
--
1.7.12.4
- [Qemu-trivial] [PATCH v5 0/8] don't use Yoda conditions, arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 2/8] usb: don't use 'Yoda conditions', arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 1/8] CODING_STYLE: Section about conditional statement, arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 6/8] spice: don't use 'Yoda conditions', arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 8/8] vmxnet3: don't use 'Yoda conditions', arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 7/8] vl: don't use 'Yoda conditions', arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 4/8] isa-bus: don't use 'Yoda conditions', arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 3/8] audio: don't use 'Yoda conditions', arei.gonglei, 2014/08/11
- [Qemu-trivial] [PATCH v5 5/8] don't use 'Yoda conditions',
arei.gonglei <=
- Re: [Qemu-trivial] [PATCH v5 0/8] don't use Yoda conditions, Michael Tokarev, 2014/08/13