[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/net/eepro100: Implement read-only bits in
Re: [Qemu-trivial] [PATCH] hw/net/eepro100: Implement read-only bits in MDI registers
Mon, 9 Jun 2014 15:46:31 +0100
On 8 June 2014 13:27, Peter Maydell <address@hidden> wrote:
> On 8 June 2014 12:31, Michael Tokarev <address@hidden> wrote:
>> 07.06.2014 20:52, Peter Maydell wrote:
>>> Although we defined an eepro100_mdi_mask array indicating which bits
>>> in the registers are read-only, we weren't actually doing anything with
>>> it. Make the MDI register-read code use it rather than manually making
>>> registers 2 and 3 totally read-only and the rest totally read-write.
>> s/register-read/register-write/ -- can be fixed when applying.
>> I'm not sure this is "trivial enough", because the side effect is
>> not obvious, at least not to someone not familiar with eepro100
>> registers and their usage.
> Mmm, but do you want to suggest a better queue? I did check
> that Linux could still boot and talk to the network via an eepro100.
Stefan has agreed to take this through the net queue;
I'll resend with the commit message errors you noted fixed.