[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with e
Re: [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()
Sun, 25 May 2014 18:36:04 +0400
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0
25.05.2014 18:29, Jan Kiszka wrote:
> On 2014-05-25 10:44, Le Tan wrote:
>> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
>> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
>> have been removed because @fmt of error_report() should not contain newline.
>> Also fix some coding style issues.
> Let's do the "also" part in a separate patch. It's more than one or two
> trivial pass-by style fixes, and some people may like the fprintf
> conversion while having different views on the other changes.
I think he misunderstood.
I told him that his previous patch had its own whitespace issues,
ie, it _adds_ whitespace errors.
In another reply I told him it is usually a good idea to fix style
issues in the code the patch touches -- this means, close to, if a
line being changed for something else has an unrelated style issue,
it should be fixed too. (An example was space between function name
and its arguments in fprintf argument list, while converting that
fprintf to error_report).
But it looks like he took this advise in much more broad way and
fixed _all_ whitespace/style issues in the files he touches. Oh
And yes, definitely, please don't mix it like this. Usually, these
code style issues should not be touched by its own, only if you
change nearby code.