[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: remove bashism

From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [PATCH] configure: remove bashism
Date: Mon, 05 May 2014 16:10:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Il 02/05/2014 13:41, Michael Tokarev ha scritto:
Commit e26110cfc67d48 added a check for shacmd to create a hash
for modules.  This check in configure is using bash construct &>
to redirect both stdout and stderr, whcih does fun things on some
shells.  Get rid of it, use standard redirection instead.

Cc: Fam Zheng <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 2fbec59..7442790 100755
--- a/configure
+++ b/configure
@@ -2627,7 +2627,7 @@ done
 if test "$modules" = yes; then
     shacmd_probe="sha1sum sha1 shasum"
     for c in $shacmd_probe; do
-        if which $c &>/dev/null; then
+        if which $c >/dev/null 2>&1; then

Applied, and Cced qemu-stable too.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]