[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] qmp: Report path ambiguity error.

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH] qmp: Report path ambiguity error.
Date: Mon, 05 May 2014 13:31:50 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0

05.05.2014 13:26, Andreas Färber пишет:
>> 03.05.2014 12:38, Michael Tokarev wrote:

>>> +        error_set(errp,
>>> +                  ambiguous ? "Path '%s' is ambiguous" : 
>>> +                  path);

>> I've applied this version.
> Please undo. error_set() unlike error_setg() expects an ErrorClass
> argument before the string. QERR_* macro contains *two* comma-separated
> values, so it is on top filling in the device-not-found message as path
> in the ambiguous case.

Heh, I havent tried to compile it yet ;)  Ofcourse I'd find this out before
sending the pull request.  Actually this is a classic ENOCOFFEE, twice.

I'll fix this for real.  This makes way too many iterations.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]