|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-trivial] [PATCH] qmp: Remove unused variable. |
Date: | Mon, 28 Apr 2014 10:37:39 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Il 25/04/2014 17:51, Andreas Färber ha scritto:
if (ambiguous) { error_setg(errp, "Path '%s' is ambiguous.", path); } else { error_set(errp, QERR_DEVICE_NOT_FOUND, path); } My reasoning is that an ambiguous path might deliver unpredictable results (whichever it encounters first), across QEMU versions at least. But I'd like to hear Paolo's opinion, too, since he was involved in loosening requirements on paths.
I agree. I think the only loosening I did was to allow an empty path if the required type is not NULL.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |